Implementation of WebVTT subtitle support #92
Conversation
birme
force-pushed
the
v3-release-candidate
branch
from
de855d5
to
9a1dc34
Compare
|
Don't know if this is about to be completed soon and ready to be merged to v3-release-candidate branch. I'd recommend to clean up the PR a bit first (use rebase to squash some commits) and rebase this branch with the current head of the v3-release-candidate branch |
It should be completed soon, just making sure it is working with |
Sgtfishtank
force-pushed
the
subtitle-new-implementation
branch
from
3ca5b07
to
6b6fefc
Compare
tobbee
force-pushed
the
subtitle-new-implementation
branch
from
474b0ca
to
6352376
Compare
Sgtfishtank
changed the title
Sgtfishtank
changed the title
Sgtfishtank
force-pushed
the
subtitle-new-implementation
branch
from
d6e98ff
to
83b7d6f
Compare
Sgtfishtank
force-pushed
the
subtitle-new-implementation
branch
from
bc6b0aa
to
18ca43c
Compare
There was a problem hiding this comment.
Just some small changes. Update the readme and have @Nfrederiksen have a glance at it and we are good to merge!
Sgtfishtank
force-pushed
the
subtitle-new-implementation
branch
from
bbf676c
to
5038953
Compare
Support for VOD with subtitles. A dummy URL can be provided as a fallback when no subtitle segments are available --------- Co-authored-by: Jonas Birmé <[email protected]> removed unnecessary files from testvectors and added a new test added support for starting without subs and added dummy fallback on all vods with subs enabled added bugfix to aduio solved issue regarind deltaTime/playhead position solved bug regarding overwrighting and shifting of subtitltes chore: removed mac OS file chore: remove mac OS file fixed code review comments updated documentation forgot to account for capital letters and added a shouldContainSubtitleCheck removed unused varible
Sgtfishtank
force-pushed
the
subtitle-new-implementation
branch
from
5038953
to
7226cb9
Compare
Before the work was done in this PR, we did not have any support for subtitles in hls-vodtolive. This pr will solve that by implementing support for WebVTT subtitles.
How it works is that it takes a subtitle playlist from a VOD and splits it into smaller playlists, similar to how audio and video do it. The biggest difference in how it works is that it looks at each segment and checks if the duration is longer than the corresponding video segment and if it is longer it splits it into smaller segments, where it changes the URI to a predetermined URI where we you can handle the slicing of the actual WebVTT file. The other major difference is that if a VOD without subtitles is loaded after VOD with subtitles, we will create dummy segments with a predetermined URI where you can server empty WebVTT files to ensure that everything runs smoothly if you add a VOD with subtitles later.
In this PR there has also been done a bit of a refactoring to increase the readability of the code.
This PR aims to solve issue #50