fix: added saved-prod-id when manually adding id, removed unused call…

…-saved-prod-id from globalstate
Eyevinn · Dec 2, 2024 · ec555db · ec555db
1 parent 912ed19
commit ec555db
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 11 deletions.
diff --git a/src/components/calls-page/calls-page.tsx b/src/components/calls-page/calls-page.tsx
@@ -58,22 +58,14 @@ export const CallsPage = () => {
     if (selectedProductionId) {
       setProductionId(selectedProductionId);
     }
-  }, [selectedProductionId, dispatch]);
+  }, [selectedProductionId]);
 
   useEffect(() => {
     if (isEmpty && !paramProductionId && !paramLineId) {
       navigate("/");
     }
   }, [isEmpty, paramProductionId, paramLineId, navigate]);
 
-  useEffect(() => {
-    console.log("productionId", productionId);
-  }, [productionId]);
-
-  useEffect(() => {
-    console.log("addCallActive", addCallActive);
-  }, [addCallActive]);
-
   const runExitAllCalls = async () => {
     setProductionId(null);
     Object.entries(calls).forEach(([callId]) => {

diff --git a/src/components/error.tsx b/src/components/error.tsx
@@ -37,6 +37,7 @@ export const ErrorBanner: FC = () => {
     if (error.callErrors) {
       // eslint-disable-next-line @typescript-eslint/no-unused-vars
       Object.entries(error.callErrors).forEach(([_, singleError]) => {
+        // _ is needed to destructure the object
         if (singleError && !displayedMessages.has(singleError.message)) {
           console.error(`Error:`, singleError.message); // Display only unique errors
           displayedMessages.add(singleError.message);

diff --git a/src/components/landing-page/join-production.tsx b/src/components/landing-page/join-production.tsx
@@ -127,6 +127,11 @@ export const JoinProduction = ({
       window.localStorage?.setItem("username", payload.username);
     }
 
+    dispatch({
+      type: "SELECT_PRODUCTION_ID",
+      payload: payload.productionId,
+    });
+
     const uuid = uuidv4();
 
     dispatch({
@@ -143,7 +148,6 @@ export const JoinProduction = ({
           mediaStreamInput: null,
           dominantSpeaker: null,
           audioLevelAboveThreshold: false,
-          selectedProductionId: null,
         },
       },
     });

diff --git a/src/global-state/types.ts b/src/global-state/types.ts
@@ -19,7 +19,6 @@ export interface CallState {
   mediaStreamInput: MediaStream | null;
   dominantSpeaker: string | null;
   audioLevelAboveThreshold: boolean;
-  selectedProductionId: string | null;
 }
 
 export type TGlobalState = {