Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add audio to join and leave line #123

Merged
merged 9 commits into from
May 7, 2024

Conversation

malmen237
Copy link
Contributor

PR with dummy-audio

@malmen237 malmen237 requested a review from martinstark April 29, 2024 15:02
@malmen237 malmen237 self-assigned this Apr 29, 2024
Copy link
Collaborator

@martinstark martinstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! A couple of ideas:

If the sounds are moved into a separate audio cue hook, we could easily extend this by adding more things, like audio cue on mute/unmute!

src/components/production-line/production-line.tsx Outdated Show resolved Hide resolved
@malmen237 malmen237 requested a review from martinstark April 30, 2024 06:17
@martinstark martinstark force-pushed the feat/add-audio-to-join-and-leave-line branch from a4a12ea to 7db7bbe Compare April 30, 2024 08:43
@martinstark
Copy link
Collaborator

looks good, waiting for audio files from Alan

@malmen237 malmen237 force-pushed the feat/add-audio-to-join-and-leave-line branch from 7db7bbe to 6df4bc5 Compare May 7, 2024 08:33
@martinstark martinstark merged commit e9b21f4 into main May 7, 2024
2 checks passed
@martinstark martinstark deleted the feat/add-audio-to-join-and-leave-line branch May 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants