-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added handling for no mediastream and no mediastreamtrack #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding error handling is not a chore
, chores are things like updating README, dependencies, code syntax (without changing behaviour).
This adds a new feature to the app, it changes the behaviour of the app, in the form of showing error messages for cases that would otherwise fail silently, giving no hint to the user that things are broken.
Semantically, I think this commit should be a feat:
This is important in contexts where an app may have automated release scripts. A chore
commit will be ignored by the release script since it, semantically, does not come with any changes to the behaviour of the application. A fix
commit would trigger a patch version bump (0.0.X). Semantically, a fix
corrects the (buggy) behaviour of an already existing feature. A feat
commit would trigger a minor version bump (0.X.0), meaning new functionality has been added to the app. Any version change would trigger a new release of the application.
(to complete the above, a fix!:
or feat!:
commit would represent a bug fix or feature that causes breaking changes to the application API, triggering a major (X.0.0) version bump.)
@martinstark Do I need do create a new brach that is named correctly or is it enough to just rename the PR? So that the branch and the commit still have the faulty naming or should I redo the brach and the commit to get it right throughout? |
it's fine if you just rename the commit with |
b28a3b1
to
e7db952
Compare
No description provided.