Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add productions list to manage view #180

Closed
wants to merge 10 commits into from

Conversation

malmen237
Copy link
Contributor

@malmen237 malmen237 commented Jun 28, 2024

Updated Layout!

First view:

Now all productions are displayed.
Screenshot 2024-07-09 at 08 14 00

When selected a production:

Either by clicking on one off the list-items or by writing a fetchable production-id
Screenshot 2024-07-09 at 08 14 15

@malmen237 malmen237 requested review from martinstark and birme June 28, 2024 16:24
The production ID could not be fetched. {productionFetchError.name}{" "}
{productionFetchError.message}.
</FetchErrorMessage>
{cachedProduction && !showProductionsList && (
Copy link
Collaborator

@martinstark martinstark Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think you need to check cachedProduction here? it seems unrelated to the productions list

or is the intention that it should show/hide the list depending on if the user has entered a production id?

@malmen237 malmen237 requested a review from martinstark July 9, 2024 06:36
@malmen237 malmen237 force-pushed the feat/add-productions-list-to-manage-view branch from 7f959b3 to 1d5c88f Compare July 9, 2024 06:42
@malmen237 malmen237 closed this Jul 11, 2024
@malmen237
Copy link
Contributor Author

This solution was also in PR #189 that has been merged, making this one obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants