Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop infinite loop on api error #222

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: stop infinite loop on api error #222

merged 1 commit into from
Nov 21, 2024

Conversation

Saelmala
Copy link
Contributor

@Saelmala Saelmala commented Nov 21, 2024 •
edited
Loading

Stops infinite loop of production list fetch if no manager is reached.
Error message that is shown:

@Saelmala Saelmala self-assigned this Nov 21, 2024
@Saelmala Saelmala requested review from birme and malmen237 November 21, 2024 10:19
birme
birme approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birme birme merged commit 3286036 into main Nov 21, 2024
2 checks passed
@birme birme deleted the fix/stop-infinite-loop-api-error branch November 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birme birme birme approved these changes

@malmen237 malmen237 Awaiting requested review from malmen237

Assignees

@Saelmala Saelmala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saelmala @birme