Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/multiple sessions one window #225

Merged
merged 32 commits into from
Dec 13, 2024

Conversation

malmen237
Copy link
Contributor

@malmen237 malmen237 commented Nov 29, 2024

What does this do?

Multiple calls

This allows the user to add another line-call into the call-window. A button opens a "join-production"-form which connects the user to an additional call. There is no limit for how many calls you can connect and if the window-max-width is reached then the next addition will be placed on a row beneath the first ones.
Skärmavbild 2024-11-29 kl  09 33 51 Skärmavbild 2024-11-29 kl  09 34 00

Updated leave call

Each call have a individual "leave"-button and if "back-button" or "home" is pressed that is used as a "leave all calls"-functionality.
Skärmavbild 2024-11-29 kl  09 33 08

Added confirmation when pressing a leave-call button
Screenshot 2024-12-10 at 14 04 33 Screenshot 2024-12-10 at 14 04 21

@malmen237 malmen237 marked this pull request as ready for review November 29, 2024 14:48
src/components/calls-page/calls-page.tsx Outdated Show resolved Hide resolved
src/global-state/global-state-reducer.ts Show resolved Hide resolved
src/components/error.tsx Show resolved Hide resolved
src/global-state/types.ts Show resolved Hide resolved
src/components/landing-page/join-production.tsx Outdated Show resolved Hide resolved
src/components/landing-page/use-navigate-to-production.ts Outdated Show resolved Hide resolved
src/components/production-line/production-line.tsx Outdated Show resolved Hide resolved
src/global-state/global-state-reducer.ts Outdated Show resolved Hide resolved
src/global-state/global-state-reducer.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/error.tsx Show resolved Hide resolved
src/components/landing-page/join-production.tsx Outdated Show resolved Hide resolved
src/components/landing-page/use-access-local-storage.ts Outdated Show resolved Hide resolved
src/components/landing-page/use-navigate-to-production.ts Outdated Show resolved Hide resolved
src/components/landing-page/use-navigate-to-production.ts Outdated Show resolved Hide resolved
src/components/production-line/use-rtc-connection.ts Outdated Show resolved Hide resolved
src/components/production-line/use-rtc-connection.ts Outdated Show resolved Hide resolved
src/global-state/global-state-reducer.ts Outdated Show resolved Hide resolved
src/global-state/types.ts Outdated Show resolved Hide resolved
@malmen237 malmen237 mentioned this pull request Dec 5, 2024
src/App.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM and works for me (when the change device PR is approved and the //TODO's can be removed from here).

There are improvements in UI that can be done but since there are tickets to change the UI over the upcoming sprint/sprints I think this is fine for now. One quick UI fix I'd like however is to add a border to the modal for confirming to leave all calls - the modal's background is very close in color to the page background so I think a border would be good.

@malmen237
Copy link
Contributor Author

Overall LGTM and works for me (when the change device PR is approved and the //TODO's can be removed from here).

There are improvements in UI that can be done but since there are tickets to change the UI over the upcoming sprint/sprints I think this is fine for now. One quick UI fix I'd like however is to add a border to the modal for confirming to leave all calls - the modal's background is very close in color to the page background so I think a border would be good.

Screenshot 2024-12-10 at 14 04 21 Screenshot 2024-12-10 at 14 04 33

@martinstark martinstark changed the base branch from main to development December 12, 2024 10:56
@malmen237 malmen237 force-pushed the feat/multiple-sessions-one-window branch from 5132efe to c4d153c Compare December 13, 2024 14:12
@LucasMaupin LucasMaupin merged commit 08e4b92 into development Dec 13, 2024
2 checks passed
@LucasMaupin LucasMaupin deleted the feat/multiple-sessions-one-window branch December 13, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants