-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/multiple sessions one window #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM and works for me (when the change device PR is approved and the //TODO's can be removed from here).
There are improvements in UI that can be done but since there are tickets to change the UI over the upcoming sprint/sprints I think this is fine for now. One quick UI fix I'd like however is to add a border to the modal for confirming to leave all calls - the modal's background is very close in color to the page background so I think a border would be good.
|
… for mobile and links
…new state-structure
…dundant join-production
…new state-structure
Co-authored-by: Lucas Maupin <[email protected]>
…-saved-prod-id from globalstate
…-production-component
…riables to global state
5132efe
to
c4d153c
Compare
What does this do?
Multiple calls
This allows the user to add another line-call into the call-window. A button opens a "join-production"-form which connects the user to an additional call. There is no limit for how many calls you can connect and if the window-max-width is reached then the next addition will be placed on a row beneath the first ones.
Updated leave call
Each call have a individual "leave"-button and if "back-button" or "home" is pressed that is used as a "leave all calls"-functionality.
Added confirmation when pressing a leave-call button