29/add loader to production list #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmen237
changed the title
martinstark
reviewed
Apr 8, 2024
martinstark
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Tested it locally, since it's so quick I still think it's probably mostly distracting that it just blinks on and off (and the pretty dots never even have time to animate).
I'm not sure how much time we want to spend here, but it's possible we want a minimum time that it's displayed (3s for it to have time to finish an animation round)
martinstark
requested changes
Apr 10, 2024
malmen237
force-pushed
the
feat/add-loader-production-list
branch
from
bce4ffa to
d6dba63
Compare
martinstark
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.