Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: co64 could use too much memory of the size overflowed 32 bits #405

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: co64 could use too much memory of the size overflowed 32 bits #405

merged 1 commit into from
Jan 20, 2025

Conversation

eric
Copy link
Contributor

@eric eric commented Jan 20, 2025

No description provided.

tobbee
tobbee approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@tobbee tobbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty weird case, but surely a possible overflow. Good to have a small piece of data to test it.

@tobbee tobbee merged commit 2330aaa into Eyevinn:master Jan 20, 2025
9 checks passed
@eric
Copy link
Contributor Author

eric commented Jan 20, 2025

Yep. It took 8 hours of fuzzing to discover it. Looking at the other implementations of expectedSize() it seemed that I had already handled promoting things to uint64 where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobbee tobbee tobbee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric @tobbee