Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password_cipher_mode to encrypt password. #1415

Open
wants to merge 1 commit into
base: 9.8-stable
Choose a base branch
from

Conversation

zongzw
Copy link
Collaborator

@zongzw zongzw commented May 29, 2019

@<reviewer_id>

What issues does this address?

Fixes #
WIP #
...

What's this change do?

Where should the reviewer start?

Any background context?

@zongzw
Copy link
Collaborator Author

zongzw commented May 29, 2019

User comments the os_password which make variable self.conf.os_password to be None.
Just post a new patch PR for them to consider this situation.

@zongzw
Copy link
Collaborator Author

zongzw commented May 29, 2019

Forget the conflict, this pr will NOT be merged eventually.
The fix to this case for master/9.8-stable will in another PR.

@zongzw
Copy link
Collaborator Author

zongzw commented May 29, 2019

Test cases:

os_password NOT commented:

(Pdb) l
379  	            resource_helper.ResourceType.pool)
380
381  	        if self.conf.password_cipher_mode:
382  	            self.conf.icontrol_password = \
383  	                base64.b64decode(self.conf.icontrol_password)
384 B->	            if self.conf.os_password:
385  	                self.conf.os_password = base64.b64decode(self.conf.os_password)
386
387  	        try:
388
389  	            # debug logging of service requests recieved by driver
(Pdb) p self.conf.os_password
'OTExNTNjODViOGRkNDE0Nw=='
(Pdb) p self.conf.icontrol_password
'admin'
(Pdb) n
> /usr/lib/python2.7/site-packages/f5_openstack_agent/lbaasv2/drivers/bigip/icontrol_driver.py(385)__init__()
-> self.conf.os_password = base64.b64decode(self.conf.os_password)
(Pdb) n
> /usr/lib/python2.7/site-packages/f5_openstack_agent/lbaasv2/drivers/bigip/icontrol_driver.py(387)__init__()
-> try:
(Pdb) p self.conf.os_password
'91153c85b8dd4147'

os_password commented:

-> if self.conf.os_password:
(Pdb) p self.conf.os_password
None
(Pdb) n
> /usr/lib/python2.7/site-packages/f5_openstack_agent/lbaasv2/drivers/bigip/icontrol_driver.py(387)__init__()
-> try:
(Pdb) p self.conf.os_password
None

Copy link
Contributor

@Niklaus-xie Niklaus-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems only for patch. won't merge this one. put a -2 here .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants