set initial font size in px on the body and then use it as the basis … #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for rem sizing throughout (no ems) relates #84
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 5 5
Lines 83 83
=======================================
Hits 77 77
Misses 6 6Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for rem sizing throughout (no ems)
Nice point made by Sohil about setting an initial font size on the body in pixels, then using rem to refer to that throughout for consistency. Please see Sohil's comments (I've put them in the issue) for details.
relates #84