Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes component #37

Merged
merged 6 commits into from
Apr 8, 2016
Merged

Notes component #37

merged 6 commits into from
Apr 8, 2016

Conversation

andrewMacmurray
Copy link
Contributor

#33 #12 #11

Basic skeleton of a note taking component, makes a post request to the server, opens in a modal, needs to be refactored to be more generic (i.e. take different notes formats)

showModal: false,
sent: false
}
this.setState = this.setState.bind(this)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you binding setState?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol oh dear

unbound this.setState
@eliasmalik eliasmalik merged commit dfd57bf into master Apr 8, 2016
@eliasmalik eliasmalik deleted the notes branch April 8, 2016 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants