Add test_play, rename fa.play to fa.run

src/client/_clientwindow.py

@@ -1937,8 +1937,7 @@ def handle_game_launch(self, message):
 
         game_info = dict(uid=message['uid'], recorder=self.login, featured_mod=message[modkey], game_time=time.time(), version_info=version_info)
 
-
-        fa.play(game_info, self.relayServer.serverPort(), arguments)
+        fa.run(game_info, self.relayServer.serverPort(), arguments)
 
 
 

src/fa/__init__.py

@@ -31,7 +31,7 @@
 
 # We only want one instance of Forged Alliance to run, so we use a singleton here (other modules may wish to connect to its signals so it needs persistence)
 from process import instance as instance
-from play import play
+from play import run
 from replay import replay
 
 import check

src/fa/play.py

@@ -17,7 +17,7 @@
 #-------------------------------------------------------------------------------
 from fa import mods
 
-from process import instance
+from .process import instance
 
 import util
 import os
@@ -52,7 +52,7 @@ def build_argument_list(game_info, port, arguments=None):
 
     #live replay
     arguments.append('/savereplay')
-    arguments.append('gpgnet://localhost/' + str(game_info['uid']) + "/" + str(game_info['recorder']) + '.SCFAreplay')
+    arguments.append('"gpgnet://localhost/' + str(game_info['uid']) + "/" + str(game_info['recorder']) + '.SCFAreplay"')
 
     #disable bug reporter
     arguments.append('/nobugreport')
@@ -63,9 +63,10 @@ def build_argument_list(game_info, port, arguments=None):
     return arguments
 
 
-def play(game_info, port, arguments=None):
+def run(game_info, port, arguments=None):
     """
     Launches Forged Alliance with the given arguments
     """
+    logger.info("Play received arguments: %s" % arguments)
     arguments = build_argument_list(game_info, port, arguments)
     return instance.run(game_info, arguments)

tests/fa/test_play.py

@@ -0,0 +1,21 @@
+__author__ = 'Sheeo'
+
+from flexmock import flexmock
+
+process_mock = flexmock()
+
+import fa
+import fa.play
+
+fa.play.instance = process_mock
+
+
+def test_launches_process_with_given_arguments():
+    game_info = {
+        'uid': 0,
+        'recorder': 'Sheeo'
+    }
+    args = ['/some-arg', 'test']
+    process_mock.should_receive('run').with_args(game_info, args).and_return(True).once()
+    assert fa.run(game_info, 0, args)
+