Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with ergochat #3038

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Add compatibility with ergochat #3038

merged 2 commits into from
Oct 15, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #3038 (a690f8e) into develop (291b741) will increase coverage by 0.03%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

❗ Current head a690f8e differs from pull request most recent head 688fa34. Consider uploading reports for the commit 688fa34 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3038      +/-   ##
=============================================
+ Coverage      59.28%   59.32%   +0.03%     
- Complexity      4488     4490       +2     
=============================================
  Files            554      555       +1     
  Lines          20167    20154      -13     
  Branches        1038     1034       -4     
=============================================
  Hits           11956    11956              
+ Misses          7661     7651      -10     
+ Partials         550      547       -3     
Files Coverage Δ
...com/faforever/client/remote/FafServerAccessor.java 81.14% <ø> (+0.83%) ⬆️
...n/java/com/faforever/client/chat/IrcChatToken.java 0.00% <0.00%> (ø)
...a/com/faforever/client/chat/KittehChatService.java 63.56% <0.00%> (+0.64%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc4c7b...688fa34. Read the comment docs.

@Sheikah45 Sheikah45 marked this pull request as ready for review October 15, 2023 22:11
@Sheikah45 Sheikah45 merged commit 8374d7b into develop Oct 15, 2023
4 of 5 checks passed
@Sheikah45 Sheikah45 deleted the feature/ergochat branch October 15, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant