Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load webViews in fxml #3071

Closed
wants to merge 1 commit into from

Conversation

Sheikah45
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: Patch coverage is 48.35165% with 47 lines in your changes missing coverage. Please review.

Project coverage is 58.88%. Comparing base (d87f32f) to head (87d7912).
Report is 187 commits behind head on develop.

Files with missing lines Patch % Lines
...java/com/faforever/client/news/NewsController.java 0.00% 20 Missing ⚠️
...orever/client/fx/DualStringListCellController.java 0.00% 8 Missing ⚠️
...rever/client/tournament/TournamentsController.java 0.00% 7 Missing ⚠️
...va/com/faforever/client/units/UnitsController.java 0.00% 7 Missing ⚠️
...forever/client/chat/MatchmakingChatController.java 83.33% 1 Missing ⚠️
...aforever/client/chat/PrivateChatTabController.java 83.33% 1 Missing ⚠️
...java/com/faforever/client/coop/CoopController.java 83.33% 1 Missing ⚠️
...ent/notification/ServerNotificationController.java 88.88% 0 Missing and 1 partial ⚠️
...ever/client/tutorial/TutorialDetailController.java 90.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3071      +/-   ##
=============================================
+ Coverage      58.84%   58.88%   +0.03%     
- Complexity      4446     4456      +10     
=============================================
  Files            560      560              
  Lines          20293    20326      +33     
  Branches        1025     1025              
=============================================
+ Hits           11942    11969      +27     
- Misses          7807     7815       +8     
+ Partials         544      542       -2     
Files with missing lines Coverage Δ
...forever/client/chat/AbstractChatTabController.java 72.99% <100.00%> (-0.18%) ⬇️
...om/faforever/client/chat/ChannelTabController.java 86.20% <100.00%> (+0.34%) ⬆️
.../java/com/faforever/client/theme/ThemeService.java 0.93% <ø> (ø)
...forever/client/chat/MatchmakingChatController.java 57.14% <83.33%> (+2.59%) ⬆️
...aforever/client/chat/PrivateChatTabController.java 63.23% <83.33%> (+1.33%) ⬆️
...java/com/faforever/client/coop/CoopController.java 58.22% <83.33%> (+0.80%) ⬆️
...ent/notification/ServerNotificationController.java 65.11% <88.88%> (+2.61%) ⬆️
...ever/client/tutorial/TutorialDetailController.java 80.00% <90.00%> (ø)
...rever/client/tournament/TournamentsController.java 0.00% <0.00%> (ø)
...va/com/faforever/client/units/UnitsController.java 0.00% <0.00%> (ø)
... and 2 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d87f32f...87d7912. Read the comment docs.

@Sheikah45 Sheikah45 marked this pull request as draft December 3, 2023 15:01
@Sheikah45 Sheikah45 closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant