We'll pick this up in the 4th developers iteration

I'm not sure if it being integrated would make it rated. I think only assassination is rated. @Askaholic could you help us with that question?

Yes I believe you’re correct, it would have to be added as a valid victory condition in the server code.

https://github.com/FAForever/server/blob/a6c626afb7b25224988fbe9471c28d8f32a1895f/server/games/game.py#L656

Would that be a difficult change? Bear with me, I have no knowledge of the setup or architecture of the server 😄

No it wouldn’t be very difficult

Then the remaining question is who decides that the mode is rated or not 😄 , is there previous suggestions or decisions on this topic?

Great question. I think history won’t really help us here as it probably was determined by a lone dev in the past who just decided how the rating decision should work. I would think some consortium of the balance, game and dev teams might make sense, since it’s kindof more of a metagame decision.

I've started the discussion with the balance team in their channel

The balance team is in favor. That's one down. What other dev teams would be involved in this decision?

I’d probably see what @Brutus5000 and @Sheikah45 think.

I am fine with it. Seems to me to be on the same level as full share vs no share, just has to be clearly communicated which it is in game

I was thinking of an announcement at the start, like the pause announcement?

What about just some icon like full vs no share?

Since generally people are annoyed by the text

I should not have any stakes in this decision. But I like the idea from a players perspective.

What about just some icon like full vs no share?

Since generally people are annoyed by the text

@Sheikah45 Where is this icon?

I think we can call it and that we can proceed to make it rated. @Askaholic are you available to make the server changes, or should I ask BlackYps?

What about just some icon like full vs no share?

Since generally people are annoyed by the text

@Sheikah45 Where is this icon?

It might not be an icon but I am talking about the info in the scoreboard

@Garanas One thing I thought of that I never tested with the mod is to make sure units are still transferred when a player gets disconnected.

I'll test it thoroughly when integrating it 😃 . If we put it on the (standard) scoreboard then people may not see it because of UI mods replacing the scoreboard

I would probably be inclined to say that is on the scoreboard author to update it to reflect the information. As historically by now we have established like info like that is on the scoreboard. But that is just my opinion.

Rather than having a text announcement every game.

You should ask @BlackYps. I should be able to find time for code review and making a release though.

I would probably be inclined to say that is on the scoreboard author to update it to reflect the information. As historically by now we have established like info like that is on the scoreboard. But that is just my opinion.

Fair enough, I agree

Yes I believe you’re correct, it would have to be added as a valid victory condition in the server code.

https://github.com/FAForever/server/blob/a6c626afb7b25224988fbe9471c28d8f32a1895f/server/games/game.py#L656

So this is supposed to get integrated into the base game? I believe the relevant lines would then look like this

if self.gameOptions["Victory"] not in (Victory.DEMORALIZATION, Victory.DECAPITATION):
    await self.mark_invalid(ValidityState.WRONG_VICTORY_CONDITION)

And where does it get the DECAPITATION value from?

On the server the victory is just an enum that matches the victory conditions to integers. I am not sure where those originate from, but they also seem to be saved in the database.

I'll soon start on implementing this so that we can ship it with the 4th development iteration. Has there been work on the server on the matter?

No, not yet

The server and database work for this is done.