Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix personal shields reflecting above the water surface #6583

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Dec 12, 2024

Description of the proposed changes

Fixes #5381.

Not sure if the changes need comments, as I have no experience with the shaders.

Testing done on the proposed changes

Spawn rambo preset SACUs underwater, the shield mesh shouldn't show up above the water. Spawning multiple in one spot makes it easier to see.

Before:
{F455D36F-388D-4480-95E7-95BD3DE59315}

After:
{8167D248-C658-4663-8406-AF651B24EA7F}

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added type: bug area: graphics Anything Related to the Game Graphics labels Dec 12, 2024
@lL1l1 lL1l1 added this to the Development I of 2025 milestone Dec 12, 2024
@lL1l1 lL1l1 requested a review from BlackYps December 12, 2024 08:54
@lL1l1 lL1l1 marked this pull request as ready for review December 22, 2024 11:31
Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as experienced as BlackYps with the shaders, but I do believe that this is the correct solution.

Copy link
Contributor

@BlackYps BlackYps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the correct way to do it

@Garanas Garanas merged commit 12c3305 into FAForever:develop Dec 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Anything Related to the Game Graphics type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ive seen a ghost
3 participants