Shift session cleanup @transactional to repository

Fixes timeouts and inconsistent state when large amounts of session stack up.
FAForever · Oct 20, 2024 · cb53412 · cb53412
1 parent fa137ef
commit cb53412
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/main/kotlin/com/faforever/icebreaker/persistence/IceSessionEntity.kt b/src/main/kotlin/com/faforever/icebreaker/persistence/IceSessionEntity.kt
@@ -6,6 +6,7 @@ import jakarta.inject.Singleton
 import jakarta.persistence.Entity
 import jakarta.persistence.Id
 import jakarta.persistence.Table
+import jakarta.transaction.Transactional
 import org.slf4j.LoggerFactory
 import java.time.Instant
 import java.util.UUID
@@ -23,6 +24,7 @@ data class IceSessionEntity(
 private val LOG = LoggerFactory.getLogger(IceSessionRepository::class.java)
 
 @Singleton
+@Transactional
 class IceSessionRepository : PanacheRepository<IceSessionEntity> {
     fun existsByGameId(gameId: Long) = count("gameId = ?1", gameId) != 0L
 

diff --git a/src/main/kotlin/com/faforever/icebreaker/service/SessionService.kt b/src/main/kotlin/com/faforever/icebreaker/service/SessionService.kt
@@ -104,7 +104,6 @@ class SessionService(
         }
     }
 
-    @Transactional
     @Scheduled(every = "10m")
     fun cleanUpSessions() {
         LOG.info("Cleaning up outdated sessions")