Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ready request and response #96

Merged
merged 6 commits into from
Nov 28, 2022
Merged

Add ready request and response #96

merged 6 commits into from
Nov 28, 2022

Conversation

1-alex98
Copy link
Member

@1-alex98 1-alex98 commented Sep 9, 2022

In preparation for the tournament service

@Brutus5000
Copy link
Member

@1-alex98 Is this a new message that is not on the server yet? I have never seen it.

@1-alex98
Copy link
Member Author

Related to FAForever/server#675

@Sheikah45
Copy link
Member

Hmmm wasn't there a ready message already that had been added for the matchmaker?

@1-alex98
Copy link
Member Author

@Sheikah45 yes and no.

There is a ReadyPartyRequest class. It is used nowhere. The name is unfitting because there is no party in tournament context. It also does not have the needed "featured_mod" field for the client to update the featured mod in advance.

I can delete that class if you want me too. Using it seems less of an option.

@Sheikah45
Copy link
Member

Yes I know it isn't used anywhere since it hasn't been implemented client or server side yet so was just thinking that what you have could either use it or replace it for implementation.

@1-alex98
Copy link
Member Author

Should I delete the class?

@Sheikah45
Copy link
Member

Yeah probably for the best and if we ever implement it we can make the server use the one you have created

@1-alex98
Copy link
Member Author

Yeah probably for the best and if we ever implement it we can make the server use the one you have created

Probably not tho otherwise client would think it is about a tournament game

@Sheikah45
Copy link
Member

Yeah probably for the best and if we ever implement it we can make the server use the one you have created

Probably not tho otherwise client would think it is about a tournament game

Well there is nothing tournament specific about the message. The only tournament specific thing is the client i18n but that isnt in the protocol

@1-alex98
Copy link
Member Author

Yeah probably for the best and if we ever implement it we can make the server use the one you have created

Probably not tho otherwise client would think it is about a tournament game

Well there is nothing tournament specific about the message. The only tournament specific thing is the client i18n but that isnt in the protocol

True...

@1-alex98
Copy link
Member Author

@Sheikah45 ok?

@1-alex98 1-alex98 force-pushed the feature/tournament-api branch from d4b4422 to aca2790 Compare November 19, 2022 14:53
@1-alex98
Copy link
Member Author

Please merge

@1-alex98
Copy link
Member Author

@Sheikah45

@Sheikah45 Sheikah45 merged commit f1f72d3 into develop Nov 28, 2022
@Sheikah45 Sheikah45 deleted the feature/tournament-api branch November 28, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants