-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ready request and response #96
Conversation
@1-alex98 Is this a new message that is not on the server yet? I have never seen it. |
Related to FAForever/server#675 |
Hmmm wasn't there a ready message already that had been added for the matchmaker? |
@Sheikah45 yes and no. There is a ReadyPartyRequest class. It is used nowhere. The name is unfitting because there is no party in tournament context. It also does not have the needed "featured_mod" field for the client to update the featured mod in advance. I can delete that class if you want me too. Using it seems less of an option. |
Yes I know it isn't used anywhere since it hasn't been implemented client or server side yet so was just thinking that what you have could either use it or replace it for implementation. |
Should I delete the class? |
Yeah probably for the best and if we ever implement it we can make the server use the one you have created |
Probably not tho otherwise client would think it is about a tournament game |
Well there is nothing tournament specific about the message. The only tournament specific thing is the client i18n but that isnt in the protocol |
True... |
@Sheikah45 ok? |
d4b4422
to
aca2790
Compare
Please merge |
In preparation for the tournament service