Log every attempt to join a game #1048
Open
+109
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheikah45
reviewed
Feb 18, 2025
Sheikah45
reviewed
Feb 18, 2025
Brutus5000
force-pushed
the
feature/game-join-log
branch
2 times, most recently
from
052db35 to
aef4d80
Compare
Askaholic
reviewed
Feb 22, 2025
Brutus5000
force-pushed
the
feature/game-join-log
branch
4 times, most recently
from
ef9103b to
dc6953a
Compare
|
@Askaholic don't know if brutus ever answered but we want to be able to track which users are joining more than normal games in a specific amount of time and doing that as a prometheus metric would be pretty high cardinality I would think |
Sheikah45
force-pushed
the
feature/game-join-log
branch
from
dc6953a to
74da430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs db v137