Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing routes and cronjobs. part of #445 #455

Merged

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Nov 11, 2023

All routes for clan and leaderboard are disabled with a new 503 view:
The links are still there, but will lead to this page.
image

@Sheikah45
Copy link
Member

I think your branch has stray commits. We squash and merge so you have a few commits from the last PR I believe that can be removed.

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 11, 2023

I think your branch has stray commits. We squash and merge so you have a few commits from the last PR I believe that can be removed.

updated

@Sheikah45
Copy link
Member

It still is showing the extraneous commits because you just merged the remote branch in. It will probably be better if you rebase your branch and drop the duplicate commits

@fcaps fcaps force-pushed the feature/disable_failing_features_till_fixed branch from 63c82bb to 55214cd Compare November 11, 2023 19:10
@fcaps
Copy link
Collaborator Author

fcaps commented Nov 11, 2023

yeah, long time ago since i worked with squash commits.
now it's good

@Sheikah45 Sheikah45 merged commit dcde321 into FAForever:develop Nov 11, 2023
2 checks passed
@fcaps fcaps deleted the feature/disable_failing_features_till_fixed branch November 11, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants