Enhancement - Steam Onboarding #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges, GOG as a whole is a mess still
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #541 +/- ##
========================================
Coverage 40.62% 40.62%
========================================
Files 72 72
Lines 1770 1770
Branches 214 214
========================================
Hits 719 719
Misses 1019 1019
Partials 32 32 ☔ View full report in Codecov by Sentry. |
…the setup, change styling to use new grid layout and clean up br's
…ext to improve the view
Brutus5000
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #538
Could remain un-merged until #444 is given more direction
Screen.Recording.2024-02-04.at.21.02.02.mov
Yes the input for gog username is messed up in the video - its now fixed
Included in this as well as it got raised in discord and uses the same classes:
Updates to the play/general setup page to advise users to run SC:FA so that a profile generates
See below:
Notable comments:
Having the preview showing the steam login is redundant. Users should know what that looks like in current year.