Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules text and styling preview #558

Merged
merged 12 commits into from
Jan 2, 2025

Conversation

FredrikBergelin
Copy link
Contributor

@FredrikBergelin FredrikBergelin commented Oct 25, 2024

Updated rules text and styling for all markdown pages. More changes will follow, team want to review the current changes on staging environment.

Also snowflakes are set to start in December, not October.

// FreadyFish

@Sheikah45
Copy link
Member

The only thing I am curious about is why the paths need to be hidden instead of just using the test server. @Brutus5000

@FredrikBergelin
Copy link
Contributor Author

No reason, just me not doing my homework before I start macgyvering. Will fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not written with a Russian R (the one that looks like "P")

@Brutus5000
Copy link
Member

The only thing I am curious about is why the paths need to be hidden instead of just using the test server. @Brutus5000
It has to be considered, that these kind of public markdown files are used in other places (e.g. a forum post or github which both also accept markdown). In these cases we need an absolute url.

@FredrikBergelin Can you add a screenshot of what even has changed?

@FredrikBergelin
Copy link
Contributor Author

Capture

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this became unused after reverting, it might prove useful so I left it in. It allows us to inject a class to the container so each page can be styled individually.

@FredrikBergelin
Copy link
Contributor Author

@Brutus5000 @Sheikah45 @Garanas Merry Christmas! The final texts have just been added including the new moderation page. I also made sure the markdown pages are shown over snowflakes for readability.

If any of you have time, would be great to get this up on the test server, then release it possibly before new years. Btw, how to access it?

@Sheikah45
Copy link
Member

@FredrikBergelin it looks like some linting rules failed if you can take a look at that

@FredrikBergelin
Copy link
Contributor Author

@Sheikah45 That should fix it. It got pushed from the wrong account apparently, not on my own computer.

@Sheikah45 Sheikah45 merged commit b46b564 into FAForever:develop Jan 2, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants