Fix JS code style

FAIRDataTeam · Jan 5, 2020 · b06b8f9 · b06b8f9
1 parent 2a90da4
commit b06b8f9
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 17 deletions.
diff --git a/src/main/resources/module/scripts/dialogs/about-dialog.js b/src/main/resources/module/scripts/dialogs/about-dialog.js
@@ -1,4 +1,4 @@
-/* global $, DOM, DialogSystem */
+/* global DOM, DialogSystem */
 
 class MetadataAboutDialog {
     constructor(type, specs, callbackFn, prefill) {

diff --git a/src/main/resources/module/scripts/dialogs/metadata-form-dialog.js b/src/main/resources/module/scripts/dialogs/metadata-form-dialog.js
@@ -1,4 +1,4 @@
-/* global $, DOM, DialogSystem, Refine, MetadataApiClient, StoreDataDialog */
+/* global DOM, DialogSystem, Refine, MetadataApiClient, StoreDataDialog */
 
 class MetadataFormDialog {
     constructor(specs, callbackFn, prefill) {
@@ -65,7 +65,7 @@ class MetadataFormDialog {
 
     setValue(fieldId, value) {
         const input = this.elements.metadataForm.find(`#${fieldId}`);
-        if (input != null) {
+        if (input !== null) {
             if (input.is(":radio") && value === true) {
                 input.prop("checked", true);
             } else {
@@ -226,24 +226,31 @@ class MetadataFormDialog {
         });
     }
 
-    makeInputField(field) {
-        const input = $(field.type === "text" ? "<textarea>" : "<input>")
-            .attr("id", field.id)
-            .attr("name", field.id)
-            .attr("type", "text")
-            .attr("title", $.i18n(`metadata/${this.specs.id}/${field.id}/description`))
-            .prop("required", field.required);
-
+    handleInputType(field, input) {
         if (field.hidden) {
             input.attr("type", "hidden");
         } else if (field.type === "iri") {
             input
                 .attr("type", "uri")
                 .attr("placeholder", "http://");
         }
+    }
+
+    handleTypehints(field, input) {
         if (field.typehints) {
             this.makeDataList(field, input);
         }
+    }
+
+    makeInputField(field) {
+        let input = $(field.type === "text" ? "<textarea>" : "<input>")
+            .attr("id", field.id)
+            .attr("name", field.id)
+            .attr("type", "text")
+            .attr("title", $.i18n(`metadata/${this.specs.id}/${field.id}/description`))
+            .prop("required", field.required);
+        this.handleInputType(field, input);
+        this.handleTypehints(field, input);
         return input;
     }
 

diff --git a/src/main/resources/module/scripts/dialogs/post-fdp-dialog.js b/src/main/resources/module/scripts/dialogs/post-fdp-dialog.js
@@ -1,4 +1,4 @@
-/* global $, DOM, DialogSystem, MetadataHelpers, MetadataFormDialog, MetadataSpecs, MetadataApiClient */
+/* global DOM, DialogSystem, MetadataHelpers, MetadataFormDialog, MetadataSpecs, MetadataApiClient */
 
 class PostFdpDialog {
 
@@ -177,7 +177,7 @@ class PostFdpDialog {
     }
 
     preparePrefill() {
-        if (this.settings.has("metadata") && this.settings.get("metadata") != null) {
+        if (this.settings.has("metadata") && this.settings.get("metadata") !== null) {
             this.prefill = new Map(Object.entries(this.settings.get("metadata")));
         }
     }
@@ -392,7 +392,7 @@ class PostFdpDialog {
             } else {
                 formDialog.displayError(result.exceptionName, result.exception);
             }
-        }
+        };
     }
 
     // show parts

diff --git a/src/main/resources/module/scripts/dialogs/store-data-dialog.js b/src/main/resources/module/scripts/dialogs/store-data-dialog.js
@@ -1,4 +1,4 @@
-/* global $, DOM, DialogSystem, MetadataHelpers, MetadataStorageSpecs */
+/* global DOM, DialogSystem, MetadataHelpers, MetadataStorageSpecs */
 
 class StoreDataDialog {
 

diff --git a/src/main/resources/module/scripts/helpers.js b/src/main/resources/module/scripts/helpers.js
@@ -1,4 +1,4 @@
-/* global $, theProject, Refine, window, DialogSystem */
+/* global theProject, Refine, DialogSystem */
 
 let MetadataHelpers = {
     moduleName: "metadata"

diff --git a/src/main/resources/module/scripts/menu-bar-extension.js b/src/main/resources/module/scripts/menu-bar-extension.js
@@ -1,4 +1,4 @@
-/* global $, lang, ExtensionBar, PostFdpDialog, StoreDataDialog, MetadataAboutDialog, MetadataHelpers */
+/* global lang, ExtensionBar, PostFdpDialog, StoreDataDialog, MetadataAboutDialog, MetadataHelpers */
 
 // Load the localization file
 var dictionary = {};