-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to Maven Central repository #3
Merged
luizbonino
merged 24 commits into
FAIRDataTeam:master
from
dennisvang:issue1-maven-central
Nov 4, 2024
Merged
Publish to Maven Central repository #3
luizbonino
merged 24 commits into
FAIRDataTeam:master
from
dennisvang:issue1-maven-central
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
major version increment because the change in namespace is backward incompatible, even though there are no functional changes
central portal validation failed with Failed to get coordinates from pom file io/github/dennisvang/spring-rdf-migration/2.0.0dev0/spring-rdf-migration-2.0.0dev0.pom
… url maven central cannot handle urls with variables
GPG signing requires github secrets, but these are not available when a workflow is triggered by a PR from a forked repository. Moreover, GPG signing is only required for publication anyway, so it is still used in the maven-publish workflow.
I would suggest a squash merge. |
4 tasks
luizbonino
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements publication to the Maven Central repository (fixes #2):
groupId
fromnl.dtls
toorg.fairdatateam.rdf
(publication to maven central requires verified domain)nl.dtls
toorg.fairdatateam.rdf
for consistencymaven-ci.yml
) from publication workflow (maven-publish.yml
)pom.xml
and workflows for publication to Maven Central Portal2.0.0
) because the namespace changes require changes in dependent repositoriesTODO:
io.github.dennisvang
toorg.fairdatateam.rdf