Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to Maven Central repository #3

Merged
merged 24 commits into from
Nov 4, 2024

Conversation

dennisvang
Copy link
Contributor

@dennisvang dennisvang commented Oct 25, 2024

This PR implements publication to the Maven Central repository (fixes #2):

  • changed groupId from nl.dtls to org.fairdatateam.rdf (publication to maven central requires verified domain)
  • changed package namespace (and corresponding paths) from nl.dtls to org.fairdatateam.rdf for consistency
  • separated build/test workflow (maven-ci.yml) from publication workflow (maven-publish.yml)
  • simplified and upgraded workflows
  • configured pom.xml and workflows for publication to Maven Central Portal
  • bumped major version (2.0.0) because the namespace changes require changes in dependent repositories

TODO:

  • update groupId from io.github.dennisvang to org.fairdatateam.rdf
  • configure repository secrets (GPG key, central portal access token)

major version increment because the change in namespace is backward incompatible,
even though there are no functional changes
central portal validation failed with
Failed to get coordinates from pom file io/github/dennisvang/spring-rdf-migration/2.0.0dev0/spring-rdf-migration-2.0.0dev0.pom
… url

maven central cannot handle urls with variables
GPG signing requires github secrets, but these are not available when a workflow is triggered by a PR from a forked repository.
Moreover, GPG signing is only required for publication anyway, so it is still used in the maven-publish workflow.
@dennisvang dennisvang marked this pull request as ready for review October 28, 2024 15:53
@dennisvang
Copy link
Contributor Author

I would suggest a squash merge.

@luizbonino luizbonino merged commit f47ed22 into FAIRDataTeam:master Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish to to Github packages or Maven Central
2 participants