Adds multiple input axis and doi reference #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copy the raw text representation of NXidentifier over by hand, the base_class_template branch will not be merged before all changes for EM and APM are implemented |
rettigl
approved these changes
Oct 31, 2023
lukaspie
reviewed
Oct 31, 2023
lukaspie
reviewed
Oct 31, 2023
lukaspie
approved these changes
Nov 2, 2023
|
I added a ToDo for an NXcalibration example with multiple inputs to FAIRmat-NFDI/pynxtools#489. |
lukaspie
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Adds multiple input axis and doi reference * Adds input and output paths * Adds NXidentifier * Update fit_function docstring * Updates from review * Explicitly state naming rules * Remove dim for input_SYMBOL * Adds dim before attributes * Use NXcite * Remove requiredness of doi * Updates NXcalibration to use method, reference and object * Add MAPPING * Updates docstring for calibration references * Docstring refinements # Conflicts: # contributed_definitions/nyaml/NXcalibration.yaml
lukaspie
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Adds multiple input axis and doi reference * Adds input and output paths * Adds NXidentifier * Update fit_function docstring * Updates from review * Explicitly state naming rules * Remove dim for input_SYMBOL * Adds dim before attributes * Use NXcite * Remove requiredness of doi * Updates NXcalibration to use method, reference and object * Add MAPPING * Updates docstring for calibration references * Docstring refinements # Conflicts: # contributed_definitions/nyaml/NXcalibration.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
This uses NXidentifier from #51. @mkuehbach What are your plans with merging NXidentifier?