Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definitions #307

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Update definitions #307

merged 5 commits into from
Apr 11, 2024

Conversation

domna
Copy link
Collaborator

@domna domna commented Apr 8, 2024

No description provided.

@coveralls
Copy link

coveralls commented Apr 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8647598148

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 77.864%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/convert.py 2 74.29%
Totals Coverage Status
Change from base Build 8523541059: 0.0%
Covered Lines: 2610
Relevant Lines: 3352
💛 - Coveralls

lukaspie
lukaspie approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, XPS example are also still working.

@domna domna merged commit 691ec5e into master Apr 11, 2024
7 checks passed
@domna domna deleted the update-definitions branch April 11, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaspie lukaspie lukaspie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domna @coveralls @lukaspie