Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off deprecated graphs by default #2213. #2214

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Conversation

knirirr
Copy link
Contributor

@knirirr knirirr commented Jan 19, 2024

This only deals with the UI, specifically #2213.
Anything relating to whether nodes are correctly shown as deprecated or not is in https://github.com/FAIRsharing/FAIRsharing-API/issues/861, which has been deployed on the dev server and is awaiting a quieter time to go into production.

@knirirr knirirr requested review from prakhyatox and allysonlister and removed request for prakhyatox January 19, 2024 12:02
@allysonlister
Copy link
Contributor

Thanks. When I go to e.g. https://deploy-preview-2214--fairsharing.netlify.app/graph/5119, the deprecated records are shown by default, and there is no toggle to have them on or off. Am I looking in the wrong place?

@knirirr
Copy link
Contributor Author

knirirr commented Jan 25, 2024

That's the correct place, but not the correct result when you go there. Netlify is currently broken for me and I get something different.
This PR definitely works locally and for some people via Netlify, and does what it's supposed to, so I'll merge it anyway I think.

@knirirr knirirr merged commit dcd9f0d into dev Jan 25, 2024
5 checks passed
@knirirr knirirr deleted the default_deprecated_2213 branch January 25, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants