Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doi not found fix 2429 #2430

Merged
merged 9 commits into from
Nov 22, 2024
Merged

Doi not found fix 2429 #2430

merged 9 commits into from
Nov 22, 2024

Conversation

knirirr
Copy link
Contributor

@knirirr knirirr commented Nov 21, 2024

This should now respond properly (i.e. a warning rather than a crash) if a DOI for the wrong type of object is used.

@knirirr knirirr linked an issue Nov 21, 2024 that may be closed by this pull request
@prakhyatox prakhyatox changed the base branch from master to dev November 22, 2024 09:33
@@ -523,51 +523,61 @@ export default {
} else {
let dataPublication;
if (Array.isArray(data)) {
console.log("Array!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

dataPublication = data[0];
} else {
console.log("Object!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

@knirirr knirirr merged commit 7ef0db0 into dev Nov 22, 2024
4 checks passed
@knirirr knirirr deleted the doi_not_found_fix_2429 branch November 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing OSF DOIs via the Publications edit tab
2 participants