Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Expression::eval to a free function with other 'assemblers' #3625

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Move Expression::eval to a free function with other 'assemblers' #3625

wants to merge 56 commits into from
+640 −324

Conversation

garth-wells
Copy link
Member

@garth-wells garth-wells commented Feb 10, 2025 •
edited
Loading

Resolves #3620.

See #3620 for summary of the issues. Also improves documentation, uses multi-dimensional arrays on the Python side (Python is not C!).

TODO:

  • Pack Expression constants and coefficients on the Python side (consistent with assemblers)

@garth-wells garth-wells requested a review from jorgensd February 10, 2025 14:31
@garth-wells garth-wells added enhancement New feature or request proposal Suggested change or addition labels Feb 10, 2025
@garth-wells garth-wells added this to the 0.10.0 milestone Feb 10, 2025
@jorgensd
Copy link
Member

In general very positive to this rewrite. Only minor comments/thoughts so far.

@garth-wells garth-wells requested a review from jorgensd February 18, 2025 08:02
jorgensd
jorgensd reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@jorgensd jorgensd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some typos. Otherwise this looks good to me.

@garth-wells garth-wells force-pushed the garth/expression-eval branch from b1f6342 to 49c9031 Compare February 18, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgensd jorgensd jorgensd left review comments

@jhale jhale Awaiting requested review from jhale

Assignees
No one assigned
Labels
enhancement New feature or request proposal Suggested change or addition
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

Re-factor fem::Expression interface
2 participants
@garth-wells @jorgensd