Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflow to fix the broken build #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YasharF
Copy link

@YasharF YasharF commented Jan 16, 2025

  1. ubuntu-24.04 (aka currently ubuntu-latest) has a compatibility issue with the workflow and we need to use ubuntu-22.04 as a temporary workaround. Ref: Error - cat: /etc/docker/daemon.json: No such file or directory - ubuntu-24.04 actions/runner-images#11408 and cat: /etc/docker/daemon.json: No such file or directory actions/runner-images#10697
  2. Updated the workflow to run the test using all the current LTS versions of Node.js. The list in the matrix will need to be updated as the LTS versions change. April 2025 is probably a good time to revisit this list as node 18 will enter EoL and they are supposed to start releasing Node 24.
  3. Updated other configs to use the latest versions
  4. Removed extra comments that probably came with the original yaml template.

@YasharF YasharF changed the title Update GitHub workflow to fix build issues Update GitHub workflow to fix the broken build Jan 16, 2025
@YasharF
Copy link
Author

YasharF commented Jan 16, 2025

Not sure why this pull request didn't trigger a build, but I already tested it in my fork in this github action run: https://github.com/YasharF/mailchecker/actions/runs/12817070395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant