Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] development from d365collaborative:development #69

Merged
merged 7 commits into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion d365fo.tools/d365fo.tools.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
RootModule = 'd365fo.tools.psm1'

# Version number of this module.
ModuleVersion = '0.7.1'
ModuleVersion = '0.7.2'

# ID used to uniquely identify this module
GUID = '7c7b26d4-f764-4cb0-a692-459a0a689dbb'
Expand Down
2 changes: 1 addition & 1 deletion d365fo.tools/d365fo.tools.psm1
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
$script:ModuleRoot = $PSScriptRoot
$script:ModuleVersion = "0.7.1"
$script:ModuleVersion = "0.7.2"

# Detect whether at some level dotsourcing was enforced
$script:doDotSource = Get-PSFConfigValue -FullName d365fo.tools.Import.DoDotSource -Fallback $false
Expand Down
7 changes: 6 additions & 1 deletion d365fo.tools/functions/get-d365module.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,12 @@ function Get-D365Module {

Write-PSFMessage -Level Verbose -Message "MetadataProvider initialized." -Target $metadataProviderViaDisk

$diskModules = $metadataProviderViaDisk.ModelManifest.ListModulesInDependencyOrder()
try {
$diskModules = $metadataProviderViaDisk.ModelManifest.ListModulesInDependencyOrder()
} catch {
Write-PSFMessage -Level Warning -Message "Failed to retrieve disk modules in dependency order. Falling back to ListModules()." -Target $metadataProviderViaDisk
$diskModules = $metadataProviderViaDisk.ModelManifest.ListModules()
}

foreach ($module in $modules) {
if ($diskModules.Name -NotContains $module.Name) {
Expand Down
2 changes: 1 addition & 1 deletion d365fo.tools/functions/invoke-d365dbsync.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function Invoke-D365DbSync {
$params = @("-syncmode=$($SyncMode.ToLower())",
"-verbosity=$($Verbosity.ToLower())",
"-metadatabinaries=`"$MetadataDir`"",
"-connect=`"server=$DatabaseServer;Database=$DatabaseName; User Id=$SqlUser;Password=$SqlPwd;`""
"-connect=`"server=$DatabaseServer;Database=$DatabaseName; User Id=$SqlUser;Password='$SqlPwd';`""
)

Write-PSFMessage -Level Debug -Message "Starting the SyncEngine with the parameters." -Target $param
Expand Down
4 changes: 2 additions & 2 deletions d365fo.tools/internal/sql/rename-computer.sql
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
BEGIN TRY
EXEC sp_dropserver [@OldComputerName];
EXEC sp_dropserver @@SERVERNAME;
END TRY
BEGIN CATCH
PRINT '@OldComputerName could not be dropped!'
PRINT 'Old SQL server name could not be dropped!'
END CATCH

EXEC sp_addserver [@NewComputerName], local;