Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: DeviceAgentVector::setVariable() array element did not sync #1266

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Dec 4, 2024

Trivially, the _changed() flag was not being called like in other setVariable() methods

Test case added which would have caught this bug and for full arrays.

Thanks @ptheywood for spotting this bug, I don't think an issue was created.

Trivially, the _changed() flag was not being called like in other setVariable() methods

Test case added which would have caught this bug.
Not sure how this was missed
@Robadob Robadob added the bug label Dec 4, 2024
@Robadob Robadob requested a review from ptheywood December 4, 2024 16:37
@Robadob Robadob self-assigned this Dec 4, 2024
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue I encountered and mentioned on slack (and hand't made the issue yet.

Manylinux CI will fail until I get around to fixing it, so going to merge regardless

@ptheywood ptheywood merged commit 9c1a371 into master Dec 4, 2024
18 of 22 checks passed
@ptheywood ptheywood deleted the bugfix_2024_12_04 branch December 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants