Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #70 - cancel an expired payment #71

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cbastienbaron
Copy link
Contributor

No description provided.

@Prometee
Copy link
Member

@cbastienbaron Sorry I did not check it but the symfony/clock is not available on Symfony 5.4 making it not usable in our case, but there is a similar service created by Sylius to do the same thing: Sylius\Calendar\Provider\DateTimeProviderInterface

@cbastienbaron
Copy link
Contributor Author

hey @Prometee 🖖

there is another thing can i do ?

@Prometee
Copy link
Member

Prometee commented Feb 7, 2025

Hello @cbastienbaron !

Sorry about the delay...

It seems that the clock service is not available on Sf 5.4 and PHP 7.4, since this code will have to remain compatible with those deps, I think you were right at the first try where you set a simple DateTime instance to check the date, this is not ideal but we can't do much more.

Are you able to do so? Then if the static build is ok I will merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants