-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created landing page #282
Created landing page #282
Conversation
@codecShivam this is how it looks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@A91y overlapping fixed |
@codecShivam check I've added responsiveness to the page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue 1: Padding Adjustment
Needs some padding adjustment in the x-direction to enhance the visual spacing.
Issue 2: Overlapping Content
The content looks overlapped. Please add some gap between the elements to prevent overlapping.
Issue 3: Background Image Visibility
The background image is not visible on smaller screens. Ensure the background image is responsive and visible across different screen sizes.
Issue 4: Responsive Layout
Wrap the elements in a way that, on decreasing the screen size, one element should go below and be aligned to the center. Also, adjust the text size for different screen sizes to maintain readability and alignment.
Issue 5: Text Visibility
The text is not visible. Improve the text alignment or background to enhance visibility.
General Suggestions for Improvement
- Breakpoints: Focus on creating three breakpoints to handle different screen sizes. Adjust sizes, alignments, and spacing accordingly.
- Text Size: Ensure text sizes are responsive and legible on all devices.
- Alignment: Maintain proper alignment to ensure elements do not overlap and are visually appealing.
Additional Suggestion
To ensure the design is properly viewed on all screens and devices, use the extension available at https://mobileview.io/.
Excellent work, @piyusesh!
@codecShivam lmk if more improvements are needed |
@codecShivam Review it ASAP |
Yeah, will review it by today. |
everything lgm!! |
lgm!! |
@codecShivam done |
fix this in hero component as well |
Thanks! @piyusesh |
Description
This PR fixes #257