Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Shipyard button in mobile view #349

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Added Shipyard button in mobile view #349

merged 5 commits into from
Oct 1, 2024

Conversation

YASH-YADAV-dynamo
Copy link
Contributor

@YASH-YADAV-dynamo YASH-YADAV-dynamo commented Sep 30, 2024 •
edited
Loading

Description

Added Shipyard button in mobile view for FOSSCU-K site.
fix : #343

Screenshots :

image

Checklist

  • I have verified that all tests pass.
  • I have added or updated documentation (if applicable).
  • I have added or updated relevant tests (if applicable).
  • I have ensured that this PR adheres to the coding standards of this project.
  • I have ensured that this PR does not introduce any breaking changes.

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for fossc ready!

Name Link
🔨 Latest commit f4a3a22
🔍 Latest deploy log https://app.netlify.com/sites/fossc/deploys/66fb9db898264f0008a24d6b
😎 Deploy Preview https://deploy-preview-349--fossc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Mr-Sunglasses
Mr-Sunglasses requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-01 at 2 59 48 AM

WhatsApp Image 2024-10-01 at 03 00 46

  • Please note the shipyard position should me as same as the desktop view ( ie. on 4th position )
  • Please fix the font-size of Shipyard Nav link in mobile view.

Mr-Sunglasses
Mr-Sunglasses reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@Mr-Sunglasses Mr-Sunglasses left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @YASH-YADAV-dynamo Awesome works 👏🏻 , Please check the suggestion.

Mr-Sunglasses
Mr-Sunglasses approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YASH-YADAV-dynamo

@Mr-Sunglasses Mr-Sunglasses merged commit 9ccb803 into FOSS-Community:main Oct 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Sunglasses Mr-Sunglasses Mr-Sunglasses approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Navbar on mobile devices does not include shipyard.
2 participants
@YASH-YADAV-dynamo @Mr-Sunglasses