Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed netifly deployment issue #356

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

ayush-129
Copy link
Contributor

[Bug]: Stop the netlify development perview on README.md changes

Fixes #347

Description

The issue refers to preventing Netlify from triggering a new preview deployment whenever there are changes made to the README.md file. Essentially, to configure the Netlify project to ignore changes to the README.md file, so it doesn't waste resources by redeploying the entire site when only documentation has changed.

Screenshot 2024-10-07 204704

command in ignore will compare the previous commit (HEAD^) to the current commit (HEAD) and check if the README.md file has changed. If only the README.md was modified, Netlify will skip the build.

One more additional line change i made in footer.jsx file as twitter react icon/fa page was showing not found. I just use another twiiter icon from there. Rest everything reamins same.

Additional Notes

Netlify deployed link to test in mine: https://prismatic-queijadas-bc8d25.netlify.app/

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for fossc ready!

Name Link
🔨 Latest commit 98631f8
🔍 Latest deploy log https://app.netlify.com/sites/fossc/deploys/6704038de93e52000830418f
😎 Deploy Preview https://deploy-preview-356--fossc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ayush-129 , Please check the suggestion

ignore = "git diff --quiet HEAD^ HEAD README.md"


[[redirects]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the redirects as we already defined them in public/_redirects

@ayush-129
Copy link
Contributor Author

yup, done

Copy link
Member

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Mr-Sunglasses Mr-Sunglasses merged commit 07d2e84 into FOSS-Community:main Oct 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Stop the netlify development perview on README.md changes
2 participants