Limited upload size

[SAMAD101]

addressed in #5

[Mr-Sunglasses]

hey @SAMAD101 test's are failing could you please check.

[SAMAD101]

hey @SAMAD101 test's are failing could you please check.

sure

[Mr-Sunglasses]

Also @SAMAD101 I have closed your PR #11 Due to the same reason. could you do the PR again

[SAMAD101]

Also @SAMAD101 I have closed your PR #11 Due to the same reason. could you do the PR again

Sure I will

[A91y]

The reason of failing test cases is that you forgot to add return statement in

@app.get("/paste/{uuid}")
def post_as_a_text(uuid):
...

[A91y]

The reason of failing test cases is that you forgot to add return statement in

@app.get("/paste/{uuid}")
def post_as_a_text(uuid):
...

cc @SAMAD101

[A91y]

The corrected function is:

@app.get("/paste/{uuid}")
def post_as_a_text(uuid):
    path = f"data/{uuid}"
    text = ""
    try:
        with open(path, 'rb') as f:
            text = f.read()
        if sys.getsizeof(text) > MAX_UPLOAD_SIZE:
            raise HTTPException(detail="File size is too large",
                                status_code=status.HTTP_413_REQUEST_ENTITY_TOO_LARGE)
        else:
            return PlainTextResponse(text)
    except Exception as e:
        print(e)
        raise HTTPException(detail="404: The Requested Resource is not found",
                            status_code=status.HTTP_404_NOT_FOUND)

[SAMAD101]

The reason of failing test cases is that you forgot to add return statement in

@app.get("/paste/{uuid}")
def post_as_a_text(uuid):
...

cc @SAMAD101

makes sense

[SAMAD101]

The corrected function is:

@app.get("/paste/{uuid}")
def post_as_a_text(uuid):
    path = f"data/{uuid}"
    text = ""
    try:
        with open(path, 'rb') as f:
            text = f.read()
        if sys.getsizeof(text) > MAX_UPLOAD_SIZE:
            raise HTTPException(detail="File size is too large",
                                status_code=status.HTTP_413_REQUEST_ENTITY_TOO_LARGE)
        else:
            return PlainTextResponse(text)
    except Exception as e:
        print(e)
        raise HTTPException(detail="404: The Requested Resource is not found",
                            status_code=status.HTTP_404_NOT_FOUND)

thanks

[Mr-Sunglasses]

@SAMAD101 Could you add a test for it [ which fails ].

[Mr-Sunglasses]

Also Please update this branch to latest main [ head ]

[Mr-Sunglasses]

Please add tests for it and sync with the main head

[SAMAD101]

@Mr-Sunglasses the test that were failing, now passes. I think we are good to go
Just resolved some conflicts with main [Head]
The test will fail now (tested locally), coz of the rate limiter. We can go ahead and merge this one.
I will look into writing on another branch under this under this issue #26
wait @A91y already did in #27

[Mr-Sunglasses]

Why it is failing because of rate limiter :(

[Mr-Sunglasses]

@SAMAD101 just do one thing close this PR and open a new fresh one, also write tests to check for Limited upload size.