Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few new Finder updates #166

Merged
merged 5 commits into from
Oct 10, 2023
Merged

A few new Finder updates #166

merged 5 commits into from
Oct 10, 2023

Conversation

profxj
Copy link
Contributor

@profxj profxj commented Oct 9, 2023

Mainly for FFFF-PZ

@profxj profxj requested a review from ntejos October 9, 2023 02:58
ntejos
ntejos requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@ntejos ntejos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some changes for the documentation. Otherwise looks good.

frb/figures/finder.py Outdated Show resolved Hide resolved
frb/figures/finder.py Outdated Show resolved Hide resolved
ntejos
ntejos approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@ntejos ntejos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@profxj
Copy link
Contributor Author

profxj commented Oct 10, 2023

not sure why tests are failing, but it is not related to this PR

@profxj profxj merged commit 6e6ab8d into main Oct 10, 2023
1 of 11 checks passed
@profxj profxj deleted the finder_dpi branch October 10, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntejos ntejos ntejos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@profxj @ntejos