Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIME telescope added to p(z|DM) #184

Merged
merged 24 commits into from
Aug 26, 2024
Merged

CHIME telescope added to p(z|DM) #184

merged 24 commits into from
Aug 26, 2024

Conversation

lluism
Copy link
Collaborator

@lluism lluism commented Jul 17, 2024

it simply adds to disk the CHIME_pzdm.npz file created by X notebook, and then loads it for the calculations.

Also visibility improvements in low-z cases plots (log scales, etc)

@lluism lluism requested a review from profxj July 17, 2024 19:36
profxj
profxj requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 additional requests:

  1. Add docs in the https://github.com/FRBs/FRB/blob/main/docs/scripts.rst file
  2. Add new tests in https://github.com/FRBs/FRB/blob/main/frb/tests/test_scripts.py

thanks!

frb/dm/prob_dmz.py Outdated Show resolved Hide resolved
frb/dm/prob_dmz.py Outdated Show resolved Hide resolved
frb/galaxies/mag_dm.py Outdated Show resolved Hide resolved
frb/scripts/pz_dm.py Outdated Show resolved Hide resolved
frb/scripts/pz_dm.py Outdated Show resolved Hide resolved
frb/scripts/pz_dm.py Outdated Show resolved Hide resolved
frb/scripts/pz_dm.py Outdated Show resolved Hide resolved
@lluism lluism requested a review from profxj July 30, 2024 02:38
@lluism
Copy link
Collaborator Author

lluism commented Jul 30, 2024

addressed comments and added extra telescopes for which we got grids from the zdm fellas

profxj
profxj requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor requests

thx!

docs/scripts.rst Show resolved Hide resolved
frb/scripts/pz_dm.py Outdated Show resolved Hide resolved
frb/tests/test_frbgalaxies.py Show resolved Hide resolved
docs/scripts.rst Outdated Show resolved Hide resolved
@lluism lluism requested a review from profxj August 16, 2024 18:54
profxj
profxj approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff!

@lluism
Copy link
Collaborator Author

lluism commented Aug 22, 2024

Changes:

  • now the user can input MW_halo_DM and host_DM separately (both have a default value of 50). This separation is needed
    to compute DM cosmic.
  • When using the "perfect" telescope, the code computes and uses DM_Cosmic instead of Extragalactic

@lluism lluism requested a review from profxj August 22, 2024 18:02
profxj
profxj approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

@profxj profxj merged commit 1eb95e0 into main Aug 26, 2024
1 of 11 checks passed
@profxj profxj deleted the mag_vs_dm branch August 26, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profxj profxj profxj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lluism @profxj