Enhance Indexer and Intake subsystems in simulation #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imulation features zzzzzzzzzzzz
…-Progathon into Intaking-stuff-sim
…-Progathon into Intaking-stuff-sim
…-Progathon into Intaking-stuff-sim
…-Progathon into Intaking-stuff-sim
PotmanNob
approved these changes
Jan 4, 2025
| @@ -101,6 +101,16 @@ public void setState(StateType state) { | |||
| this.state = state; | |||
| } | |||
|
|
|||
| // TODO: This is mad goofy | |||
| // For if you need to override set state | |||
| public void manualSetState(StateType state) { | |||
There was a problem hiding this comment.
why cant we use the regular setState method?
There was a problem hiding this comment.
use abstract classes young buck. default is BUM 🤮 🤮 🤮
|
also check if it works in sim. im too lazy to do so |
nkalupahana
reviewed
Jan 5, 2025
| import frc.robot.subsystems.Indexer.IndexerStates; | ||
|
|
||
| public enum IndexerInterfaceStates implements SubsystemStates { | ||
| SCORING("SCORING"), |
There was a problem hiding this comment.
State strings should prob be "humanized" -- "Scoring", "Off", etc.
nkalupahana
reviewed
Jan 5, 2025
| return io.hasGamepiece(); | ||
| } | ||
|
|
||
| public double getStateTime() { |
There was a problem hiding this comment.
if you want to do this often you could just make getStateTime public in Subsystem
nkalupahana
reviewed
Jan 5, 2025
| @@ -0,0 +1,36 @@ | |||
| package frc.robot.subsystems.Indexer.IndexerManager; | |||
There was a problem hiding this comment.
If this is called IndexerInterface you should rename the folder + package too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sim