Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created Checkbox prop #45

Merged
merged 12 commits into from
Feb 12, 2025
Merged

created Checkbox prop #45

merged 12 commits into from
Feb 12, 2025

Conversation

PramitaUp
Copy link
Contributor

Implemented a prop for checkboxes to use in summary page for tags.

app/components/Checkbox.tsx Outdated Show resolved Hide resolved
app/views/teleop.tsx Outdated Show resolved Hide resolved
app/summary.tsx Show resolved Hide resolved
app/components/Checkbox.tsx Show resolved Hide resolved
app/components/Checkbox.tsx Outdated Show resolved Hide resolved
saturnaliam
saturnaliam previously approved these changes Feb 8, 2025
Copy link
Member

@saturnaliam saturnaliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but persistence still has to be added

@saturnaliam saturnaliam self-requested a review February 12, 2025 22:50
Copy link
Member

@saturnaliam saturnaliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more tags but otherwise pretty good

app/api/data_types.ts Show resolved Hide resolved
@saturnaliam saturnaliam dismissed their stale review February 12, 2025 22:57

outdated i fear

@Nanobot567 Nanobot567 merged commit 2652c38 into master Feb 12, 2025
0 of 2 checks passed
@Nanobot567 Nanobot567 deleted the tag-checkboxes branch February 12, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants