-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
25w03a game tests #4385
Merged
Merged
25w03a game tests #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
added
port
Porting existing code to a different version
test
priority:high
High priority PRs that need review and work now. Review these first.
labels
Jan 17, 2025
...est-api-v1/src/main/java/net/fabricmc/fabric/impl/gametest/FabricGameTestModInitializer.java
Outdated
Show resolved
Hide resolved
...c-gametest-api-v1/src/main/java/net/fabricmc/fabric/impl/gametest/TestAnnotationLocator.java
Outdated
Show resolved
Hide resolved
…gametest/TestAnnotationLocator.java Co-authored-by: Joseph Burton <[email protected]>
haykam821
suggested changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many tests get broken by the change from a 8x8x8 empty structure template to the vanilla 1x1x1 one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge me please
Pull requests that are ready to merge
port
Porting existing code to a different version
priority:high
High priority PRs that need review and work now. Review these first.
test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tottaly overhalled Game Test module to accomdate the changes made in 25w03a.
I have added back a
@GameTest
that functions almost the same as the previous one vanilla had. The new vanilla system makes it much harder to write a test than it was before. As there was a lot of value in the magic annotation and tests that are easy to write I think it makes sense to have something similar to what we had before.The options in the new Fabric provided
@GameTest
annotation directly map the vanilla data driven options, removing the need to have a json file for each test function. Data driven tests will still work if you wish to use the vanilla system.The previous
fabric-api.gametest
andfabric-api.gametest.report-file
system properties work as they did before.fabric-api.gametest.filter
andfabric-api.gametest.verify
have been added that map directly to the vanilla gametest entrypoint options.Tests can still be ran/debuged from within a client using the
/test
command. Structures can still be loaded from snbt files as before.