Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Placeholder support to holograms #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Placeholder support to holograms #132

wants to merge 1 commit into from

Conversation

aj-rom
Copy link

@aj-rom aj-rom commented Apr 7, 2020

This allows PlaceholderAPI to hook onto the player adding/creating a hologram to register it before creation.

@Fabricio20
Copy link
Owner

Hey, thanks for the contribution. I don't think this is going to work however.

Holograms are not rendered per-player, they are global, so the placeholder will be replaced upon creation and then will be visible for everyone else exactly the same (which won't make sense).

You can test this by creating a hologram with the player name placeholder (with your patch) and having a friend join (he will see your name instead of his).

@aj-rom
Copy link
Author

aj-rom commented Apr 7, 2020

Hey thanks for getting back so fast.

Do you know of any way to register a placeholder via the PlaceholderAPI using the Minecraft server?

The reason I forked was to allow our server to use
%bungee_total% and some other server unique placeholders.

Although I don’t think there is currently a way to only register placeholder messages to a server and not a player. I did test this out and it’s working from what I can tell.

@aj-rom
Copy link
Author

aj-rom commented Apr 7, 2020

For example I know %player_name% would show up as whoever added a line or created the hologram, but having the ability to add other server placeholders might be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants