Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't draw effect rings w/gravgun equipped. #2083

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

StrawWagen
Copy link
Contributor

@StrawWagen StrawWagen commented May 3, 2024

I get why this was a feature, since the gravgun can pick up, move effects.

But I'm gonna be straight, nobody places, moves effects with the gravgun, it's a weapon you use to "play the game".
If I'm wrong, and someone does use the gravgun to place effects, I feel very confident saying they're vastly outnumbered by the players who use it solely as a weapon.

"cl_draweffectrings 0" does exist, but it's not the "default player experience", it's another, albeit very small, "barrier to entry".

Thanks for considering this very small PR, for what I feel is an equally small oversight.

@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Jul 9, 2024
@robotboy655
Copy link
Collaborator

Making prop_effect invisible with the gravity gun would also imply that it should not interact with them, if we are to apply gameplay logic here.

@StrawWagen
Copy link
Contributor Author

Yeah, but my opinion is there's more people fighting with the gravity gun, than people using it to interact with effects.

This change is really just for the small save/course building community.
It sucks to make an elaborate course with cool details everywhere, only for a bunch of yellow circles to show up when you give players the best half life 2 weapon haha.

@robotboy655 robotboy655 merged commit 128a2b8 into Facepunch:master Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement The pull request enhances current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants