Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose RPC flags in launcher #400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adytzu2007
Copy link

@adytzu2007 adytzu2007 commented Feb 23, 2025

Expose three flags (rpc.batchrequestlimit, rpc.jstracerlimit, rpc.maxresponsesize) so they can be configured through the CLI.

@HerbertJordan HerbertJordan requested review from jmpike and jenikd and removed request for jmpike February 24, 2025 07:55
@jenikd
Copy link
Collaborator

jenikd commented Feb 24, 2025

Hi @adytzu2007 you can configure these flags in config.toml file like this:

[Opera]
JSTracerLimit = 1
BatchRequestLimit = 1
MaxResponseSize = 2500000

Then you can set this config file via flag in launcher like
--config=<path to config.toml>

@adytzu2007
Copy link
Author

Then you can set this config file via flag in launcher like
--config=<path to config.toml>

Hi @jenikd , that's good to know. Is there any reason why these shouldn't also be exposed in the CLI? We tend to use CLI flags in a systemd service rather than config files.

Expose three flags (rpc.batchrequestlimit, rpc.jstracerlimit,
rpc.maxresponsesize) so they can be configured through CLI.
@adytzu2007 adytzu2007 force-pushed the adytzu2007/expose_flags branch from bc99dc3 to 50f7877 Compare February 24, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants