Best Effort User Input Validation Checks #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added checkUserInput() * Checked callsign * Checked ID * Checked IP Address
* Added baud rate value and type checking * Changed argparse input type to integer
* Expect boolean on `l`, `--loopback` option
* Convert mtu to int at argparse * Check mtu for int * Bheck for mtu >= 68 bytes * Check for mtu <= 65535 bytes
* Went back and added helpful information for each exception where possible to indicate to user what happened. * Updated some value checking to be more pythonic
* Check that the serial port path is a string
* Check for integer and NoneType values, however, Nonetype is currently impossible to get per design of argparse options * Check for integer value creater than or equal to zero
…ead timeout * Added writetimeout checks similar to readtimeout * Fixed read timeout notes to remove copy/paste errors
* Used copy paste erros with mtu arguments being checked for timeouts * Fixed if checks which were missing ending colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in #30 for best effort user input validation.
timeoutbeing aNoneTypedue to default argparse values.mtusize set to RFC 791 min/maxcallsignset to min of 3 characters and max of 7 characters