Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing raise. #1031

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix missing raise. #1031

merged 1 commit into from
Apr 18, 2024

Conversation

troiganto
Copy link
Contributor

Description

While forking the .envs.registration module for another project, I noticed that the check in EnvSpec._check_can_jsonify() doesn't actually do anything due to a missing raise.

Fixes #1030

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fix missing raise.
b1e181d 
Without this `raise`, the check in `EnvSpec._check_can_jsonify()`
doesn't actually do anything.
pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and test

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 1297a37 into Farama-Foundation:main Apr 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] Missing raise in EnvSpec._check_can_jsonify()
2 participants
@troiganto @pseudo-rnd-thoughts