Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(FrozenLake_tuto): update policy exploitation logic to handle variable sets of maximum Q-values #1037

Conversation

edelauna
Copy link
Contributor

Description

Small change to the logic in the docs/tutorial/FrozenLake_tuto.py, the existing exploitation logic only randomly chooses an action if all actions have the same q-value. Whereas it's possible for a subset of actions to have a maximum q-value.

Updating the logic to retrieve an index of q-values which are equal to the max value, and then randomly selecting an action to take.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@edelauna edelauna changed the title doc(EpsilonGreedy): update policy exploitaion logic to handle variable sets of maximum Q-values doc(FrozenLake_tuto): update policy exploitaion logic to handle variable sets of maximum Q-values Apr 26, 2024
@edelauna edelauna changed the title doc(FrozenLake_tuto): update policy exploitaion logic to handle variable sets of maximum Q-values doc(FrozenLake_tuto): update policy exploitation logic to handle variable sets of maximum Q-values Apr 26, 2024
@edelauna edelauna marked this pull request as ready for review April 26, 2024 02:52
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I understand the issue with just np.argmax but this solution looks good

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 5bf7269 into Farama-Foundation:main Apr 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants