Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shape check to MultiDiscrete __eq__ (#1044) #1045

Merged
merged 1 commit into from
May 8, 2024
Merged

Add shape check to MultiDiscrete __eq__ (#1044) #1045

merged 1 commit into from
May 8, 2024

Conversation

DenBuzz
Copy link
Contributor

@DenBuzz DenBuzz commented May 7, 2024

Description

The __eq__ method in the MultiDiscrete space needs to also check the shape of nvec before the equivalence check. If the shapes are not the same, numpy will throw a ValueError saying operands could not be broadcast together.

The fix here is to simply include a check of the shape before the nvec equivalence check.

Fixes #1044

I included a handful of tests for checking if MultiDiscrete spaces are equivalent or not. Including a test with different shaped nvecs that would have errored before these changes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR looks good

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit df97b31 into Farama-Foundation:main May 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] MultiDiscrete spaces' __eq__ method needs to check shape.
2 participants